I just pushed a bunch a small changes which should improve the visual clarity, by reducing the highlighting parts and re-using git range-diff block sign to better distinguish the diff of diffs markers from the diffs markers.

I also added before and after links to each files, improved the bookmarklet help and added a small explanation for the block markers. Feedback welcome of course.

before	after

The minus/plus with red/green background is a bit distracting visually

For the record, git range-diff actually uses the red/green background with the +/- marker.

what about just keeping the red/green bar without minus/plus?

We can try, but not sure if people will understand what they mean without the +/-.

The background contrast is also a bit dim

The background contrast of the page? Or the red/green colors? Were you in dark mode? In dark mode it's the same background and text color as for our GHA logs viewer.

I probably was in dark mode, and yeah, I find the contrast to be not ideal on both pages. But it's not terrible, so definitely a non-blocking comment :) It seems to work well, feel free to merge!

Would doing something aking to GitHub diff viewer where the whole line has a background color work better for you?

Probably not, I like the current visualization, just wanted to remove the +/- in the very left column, in particular also because the +/- is duplicated on actually changed lines.

Well, there is complexity, they are not always duplicated, we can have -+. We can see that on the exemple I gave. It means that the added line from the previous patch is removed.

Hmm, I probably don't have experience with range-diff, that's quite confusing to me. I would simply expect to see a diff from the old push to the new push, while ignoring all the other crap that happened on master in the meantime.

There isn't any crap left, a range-diff does a diff of diffs, as you would expect.

It's nevertheless quite confusing the first time you read one, as we need to show what was added and removed on the first push vs what was added and removed on the second push.

That's why there is those double markers, the first one indicates what has changed between the the first and second push, and the second marker indicates what was/is the change.

If we really wanted to, we could show a normal diff though, right? Just render the old contents and the new contents and diff them, without regarding the fact that the first version was already a "diff".

What you're describing is I think what GitHub does, it shows the diff of contents (instead of the diff of diffs), which shows a lot of unrelated changes.

Ofc I meant doing a diff between just the relevant changes, not everything.

Hum, I guess that could work. We could probably do it by removing the removed lines from the diffs (as well as stripping + from the added lines), that should get us the "final" content limited to the relevant changes of each of them and then diff those together.

I'm not saying that it's better, just that I personally find it less confusing. I think the current range diff is fine.

The advantage of range-diff is that it gives you the diff between the two push compared to master, while comparing the final relevant parts between each others only gives you the diff between the two push. Each one has his advantages and dis-advantages.

I think the current range diff is fine.

Then let's keep the range-diff for now. We can experiment later with your solution.